I wouldn't recommend selling your 50mm. Not until you have learned much more and upgraded to another prime that you really love. It's one of those lenses that people go through phases with. At first it's too tight, restricting and they hate it because of the no-zoom thing. Then they find they NEED it's low light capability. Somewhere in there they discover it's sharpness over their other stuff and fall in love with that. At which point they learn how to use a prime.
You're still in the learning phase of exposure too and this lens will come in INCREDIBLY handy as you are doing some things with that.
So, I am suggesting you bring your budget down by that $90 bucks or so for now.
So... At $300 what can you get:
Used Tamron 17-50 f/2.8
Amazon.com: Used and New: Tamron AF 17-50mm F/2.8 XR Di-II LD SP Aspherical (IF) Zoom Lens for Canon Digital SLR Cameras
you wouldnt recomend replacing the 50mm 1.8 with a 50mm 1.4 USM?
the lens you linked would replace my kit lens right? I will be shooting mostly portraits and hopefully some weddings, that being said is the lens you linked a good choice or should I get something with a focal range like this
Amazon.com: Tamron AF 28-75mm f/2.8 SP XR Di LD Aspherical (IF) for Canon Digital SLR Cameras: Electronics
I would personally prefer the 28-75, BUT on a crop sensor you may well feel the pinch at 28mm. A LOT of people say it's too tight for crop sensor. HOWEVER! I find I get into a LOT of trouble with the 17-50 at the wide end with the distortion issues. I try to never shoot at the wide end if I can.
Second reason: I also have full frame cameras and the 17-50 will not work on them. The 28-75 will.
I would not sell off the 50 until you 1. know that 50mm is the focal length you want in a good prime and 2. have the money to upgrade it.
If you are considering weddings do not buy any variable aperture lenses. They will kill you in a church. You are going to NEED the f/2.8 lenses. You are also going to need much better quality than crap, so stop trying to upgrade to "a little better" and save your money. You can't get around needing good lenses and damn good skill for a wedding.
I use the 17-50 for weddings, but I am not happy with it overall. It performs for me without fail, but it is not the quality that I want. I will upgrade it this year because of that. When I bought it I was happy as a lark with it's quality.
You are aiming for professional. Stop putting band-aids on a heart attack. You can't skimp on glass for the rigorous use you are wanting to put your equipment through. Start putting money away and buy good quality. Had I done that to begin with I'd be shooting with a 24-70 today that runs over $2000 and I would not have wasted money on temporary fixes.
Your camera body is going to need to be replaced down the line as well. It'll serve you well-for now. But eventually you will see the light-or lack of it-in your camera body and you'll need more. The dynamic range, noise level and overall abilities on an entry level body just won't cut it. I had a girl shoot a wedding with me a couple of weeks ago with your camera body. She has shot a few and she's now ready to upgrade and is kicking herself for thinking her camera and budget equipment would cut it as the primary photographer. She's going to keep second shooting for me and get the experience, but she's so disappointed in herself for thinking she could do it all with just any equipment. She's now putting everything she makes shooting toward a new body and two lenses that she feels she needs.
I am not telling you this to discourage you, but to tell you that 'good enough' is only good enough when you are on the outside coming in. Once you are in here and doing it you are going to want to go back and kick your newbie ass for thinking it. You will waste a lot of money if you start out purchasing 'for now' equipment.