Alex, I don´t want to be a party pooper. I love photography, I´m doing this as a job and I would like more people to be able to enjoy that. That´s why I created the above mentioned course.
However: expect it to be difficult, and consider a plan B!!!
Here is my take on why:
With the advance of the internet and technique in cameras, competition is increasing heavily. Many photographers couldn´t earn their living in the past. And competition is getting even tougher.
Today it is easier to learn photography than ever before. You find lots of material online, so you don´t have to pay for it, it is quick and rather easy. Logically, more people will want to become photographers, and even more, will have their own skills improved and don´t feel the need to hire photographers anymore. So more photographers, fewer customers.
With the advance in technology, photography has also become easier and will become even easier in the next few years. AI technology is conquering cameras these days, making obtaining focus a breeze. It wasn´t like that a few decades ago!!! An example for AI in photography and video is DJIs Osmo Pocket. A device with a gimbal included - it will detect your face, focus on it and keep it in the frame while you are moving. With some Sony cameras, you can register faces and the camera will recognize and prioritize them. The technology in this area has just begun and I´m sure many here int he forum will disagree, but I don´t think you can stop AI in photography.
Talking about AI: digitalization is a big factor in this too. Many people will lose their jobs due to machines doing it instead of them. That´s a fact (doesn´t have to be a bad one though - just depends on how politics will prepare our world for it). Many of those people losing their jobs will have to start from scratch with education. They will most likely choose something they love doing. Well, and photography is popular so there will be another surge of new photographers some time in the not so distant future.
One more about equipment: it is becoming cheaper and cheaper - another reason why more and more people can get decent equipment.
Not too long ago there were no real third party speedlights, so you had to buy Canon or Nikon. Today you get a ton of third-party speedlights for 20% or less of the cost. And they work. You can even use them wirelessly - for very little money.
Same with studio lighting. It used to cost you a fortune. Today it is rather easily affordable.
So to sum things up: I don´t want to destroy anybody's dream, quite the contrary - I always want to motivate people to pick up photography. But if you are young and try to find a profession for most of your life that will feed your family: reconsider it and have a plan B.